Skip to content

feat(login): add origin check at login #49560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 20, 2024
Merged

feat(login): add origin check at login #49560

merged 2 commits into from
Dec 20, 2024

Conversation

Altahrim
Copy link
Collaborator

Summary

Check Origin header on login page

Checklist

@Altahrim Altahrim added 2. developing Work in progress php Pull requests that update Php code labels Nov 29, 2024
@Altahrim Altahrim added this to the Nextcloud 31 milestone Nov 29, 2024
@Altahrim Altahrim self-assigned this Nov 29, 2024
@Altahrim Altahrim force-pushed the fix/login-origin branch 4 times, most recently from d695288 to dfaf28e Compare December 4, 2024 12:59
artonge added a commit to nextcloud-libraries/nextcloud-cypress that referenced this pull request Dec 4, 2024
@artonge
feat: Send Origin header in login request
b65ed5f 
This is need as the server is now checking that header too: nextcloud/server#49560

Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge mentioned this pull request Dec 4, 2024
Merged
artonge added a commit to nextcloud-libraries/nextcloud-cypress that referenced this pull request Dec 4, 2024
@artonge
feat: Send Origin header in login request
201a4a4 
This is need as the server is now checking that header too: nextcloud/server#49560

Signed-off-by: Louis Chemineau <[email protected]>
@Altahrim Altahrim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 5, 2024
@Altahrim Altahrim marked this pull request as ready for review December 5, 2024 09:10
@Altahrim Altahrim requested review from a team, ArtificialOwl, yemkareems and provokateurin and removed request for a team December 5, 2024 09:10
skjnldsv
skjnldsv reviewed Dec 11, 2024
View reviewed changes
@Altahrim Altahrim added the pending documentation This pull request needs an associated documentation update label Dec 11, 2024
@sorbaugh sorbaugh merged commit d4715c6 into master Dec 20, 2024
192 checks passed
@sorbaugh sorbaugh deleted the fix/login-origin branch December 20, 2024 13:53
@juliusknorr juliusknorr mentioned this pull request Dec 23, 2024
Closed
@enjeck enjeck mentioned this pull request Jan 2, 2025
Merged
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
@inet-cologne
Copy link

@Altahrim, @skjnldsv, @sorbaugh, @artonge , @canadaduane
Hey guys,
may it be that the change made here in #49560 produces somehow login problems within Nextcloud files app, Nextcloud Talk app and perhaps causing issues with Calendar subscription synchronising?
Since a couple of days after updating (several instances!!) Nextcloud Server to 30.0.5, problems were occurring that Login fails. These could be fixed by deleting and reinstalling and reconfiguring the apps.
30.0.6 does not fix the situation either but now even reinstallation does not help anymore. Login with the above mentioned iOS apps are not possible any more!!
Please see issue #50619!

Thanks for checking that!!
Chris

@inet-cologne inet-cologne mentioned this pull request Feb 15, 2025
Merged
4 tasks
@susnux
Copy link
Contributor

susnux commented Feb 23, 2025

@inet-cologne this is not included in Nextcloud 30 but only Nextcloud 31.

@Altahrim Altahrim removed the pending documentation This pull request needs an associated documentation update label Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

@provokateurin provokateurin Awaiting requested review from provokateurin provokateurin is a code owner automatically assigned from nextcloud/server-backend

Assignees

@Altahrim Altahrim

Labels
3. to review Waiting for reviews php Pull requests that update Php code
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
6 participants
@Altahrim @inet-cologne @susnux @skjnldsv @sorbaugh @artonge